Skip to content

Conversation

oleonardolima
Copy link
Contributor

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@oleonardolima oleonardolima self-assigned this Oct 8, 2025
@oleonardolima oleonardolima added chore Non-coding related work github_actions Pull requests that update GitHub Actions code labels Oct 8, 2025
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for unblocking CI, though I'm assuming this is also fixed by #2055.

ACK 4f61f1f

@notmandatory notmandatory moved this to Needs Review in BDK Chain Oct 9, 2025
@notmandatory notmandatory added this to the Wallet 3.0.0 milestone Oct 9, 2025
@notmandatory
Copy link
Member

ACK 4f61f1f

I'm on board with fixing the CI for now while #2055 is being discussed/reviewed.

@notmandatory notmandatory merged commit 8149e1b into bitcoindevkit:master Oct 9, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Oct 9, 2025
@oleonardolima oleonardolima deleted the ci/update-pinned-webpki-roots branch October 9, 2025 03:08
@oleonardolima
Copy link
Contributor Author

Yes, it was only meant to unblock the CI. Thanks for merging, I was away from the keyboard this morning.

@oleonardolima
Copy link
Contributor Author

I noticed that we also need to backport this one for the release/chain-0.23.x branch. I opened #2061 for that.

ValuedMammal added a commit that referenced this pull request Oct 9, 2025
…py fixes

c123a28 fix(electrum): clippy warnings (Leonardo Lima)
08e189f fix(example_cli): clippy warnings (Leonardo Lima)
6c43b46 fix(ci): update `webpki-roots` pinned version (Leonardo Lima)

Pull request description:

  backport #2058 and #2043 to `release/chain-0.23.x`

  ### Description

  ### Notes to the reviewers

  ### Changelog notice

  ### Checklists

  #### All Submissions:

  * [ ] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK c123a28
  notmandatory:
    ACK c123a28

Tree-SHA512: 74749c139e78f9e7ddb8dae655d73fb50938ff6eb7708bcb56f21bcc47faa9ddefa79b5c19251f5b95fc4bd351948caf9dcbb814d4629db8cb0a8b67f8083014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Non-coding related work github_actions Pull requests that update GitHub Actions code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants